Skip to content

Commit

Permalink
check popen(ldconfig) return value
Browse files Browse the repository at this point in the history
  • Loading branch information
vtjnash committed Dec 21, 2015
1 parent 791523c commit 5a66fba
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/runtime_ccall.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ static void jl_read_sonames(void)
#else
FILE *ldc = popen("/sbin/ldconfig -r", "r");
#endif
if (ldc == NULL) return; // ignore errors in running ldconfig (other than whatever might have been printed to stderr)

while (!feof(ldc)) {
ssize_t n = getline(&line, &sz, ldc);
Expand Down

3 comments on commit 5a66fba

@yuyichao
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#13719 ?

@Keno
Copy link
Member

@Keno Keno commented on 5a66fba Dec 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under what circumstances does this fail?

@vtjnash
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centos buildbots apparently

Please sign in to comment.