Skip to content

Commit

Permalink
Add pid to malloc log (#29969)
Browse files Browse the repository at this point in the history
  • Loading branch information
simonbyrne committed Nov 26, 2018
1 parent a836064 commit 58c0ed5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
*.jl.cov
*.jl.*.cov
*.jl.mem
*.jl.*.mem
*.ji

/perf*
Expand Down
5 changes: 4 additions & 1 deletion src/codegen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1744,7 +1744,10 @@ extern "C" void jl_write_coverage_data(void)

extern "C" void jl_write_malloc_log(void)
{
write_log_data(mallocData, ".mem");
std::ostringstream stm;
stm << jl_getpid();
std::string outf = "." + stm.str() + ".mem";
write_log_data(mallocData, outf.c_str());
}

// --- constant determination ---
Expand Down

2 comments on commit 58c0ed5

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.