add an error hint for min/max on an iterable (#52716)

Inspired by the discussion in
https://discourse.julialang.org/t/max-of-a-vector/108294/15

```julia
julia> max([1,2,3])
ERROR: MethodError: no method matching max(::Vector{Int64})
Finding the maximum element of an iterable is performed with `maximum`.
....
```

base/errorshow.jl

@@ -1024,6 +1024,18 @@ end
 
 Experimental.register_error_hint(string_concatenation_hint_handler, MethodError)
 
+
+# Display a hint in case the user tries to use the min or max function on an iterable
+function min_max_on_iterable(io, ex, arg_types, kwargs)
+ @nospecialize
+ if (ex.f === max || ex.f === min) && length(arg_types) == 1 && Base.isiterable(only(arg_types))
+ f_correct = ex.f === max ? "maximum" : "minimum"
+ print(io, "\nFinding the $f_correct of an iterable is performed with `$f_correct`.")
+ end
+end
+
+Experimental.register_error_hint(min_max_on_iterable, MethodError)
+
 # ExceptionStack implementation
 size(s::ExceptionStack) = size(s.stack)
 getindex(s::ExceptionStack, i::Int) = s.stack[i]

test/errorshow.jl

@@ -8,6 +8,7 @@ include("testenv.jl")
 # re-register only the error hints that are being tested here (
 Base.Experimental.register_error_hint(Base.noncallable_number_hint_handler, MethodError)
 Base.Experimental.register_error_hint(Base.string_concatenation_hint_handler, MethodError)
+Base.Experimental.register_error_hint(Base.min_max_on_iterable, MethodError)
 
 @testset "SystemError" begin
  err = try; systemerror("reason", Cint(0)); false; catch ex; ex; end::SystemError
@@ -998,6 +999,15 @@ let err_str
  @test occursin("String concatenation is performed with *", err_str)
 end
 
+let err_str
+ err_str = @except_str min([1,2,3]) MethodError
+ @test occursin("Finding the minimum of an iterable is performed with `minimum`.", err_str)
+ err_str = @except_str min((i for i in 1:3)) MethodError
+ @test occursin("Finding the minimum of an iterable is performed with `minimum`.", err_str)
+ err_str = @except_str max([1,2,3]) MethodError
+ @test occursin("Finding the maximum of an iterable is performed with `maximum`.", err_str)
+end
+
 @testset "unused argument names" begin
  g(::Int) = backtrace()
  bt = g(1)