Skip to content

Commit

Permalink
Allow ANSI escape codes in precompile test stacktrace (#38595)
Browse files Browse the repository at this point in the history 
This test was failing when run locally (depends on display).
Similar to #36858.
  • Loading branch information
@timholy
timholy committed Nov 29, 2020
1 parent 96d59f9 commit 40e4796
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/precompile.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ precompile_test_harness(false) do dir
error("break me")
end
""")
@test_warn "LoadError: break me\nStacktrace:\n [1] error" try
@test_warn r"LoadError: break me\nStacktrace:\n \[1\] [\e01m\[]*error" try
Base.require(Main, :FooBar2)
error("the \"break me\" test failed")
catch exc
Expand Down

4 comments on commit 40e4796

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - successfully executed benchmarks. A full report can be found here. cc @christopher-dG

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

Please sign in to comment.