Skip to content

Commit

Permalink
Remove AbstractString support in 1 arg findfirst and findlast (#37348)
Browse files Browse the repository at this point in the history
  • Loading branch information
@oxinabox
oxinabox committed Sep 11, 2020
1 parent 3b3ae2b commit 3db0493
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions base/array.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1788,7 +1788,7 @@ function findfirst(A)
end

# Needed for bootstrap, and allows defining only an optimized findnext method
findfirst(A::Union{AbstractArray, AbstractString}) = findnext(A, first(keys(A)))
findfirst(A::AbstractArray) = findnext(A, first(keys(A)))

"""
findnext(predicate::Function, A, i)
Expand Down Expand Up @@ -1976,7 +1976,7 @@ function findlast(A)
end

# Needed for bootstrap, and allows defining only an optimized findprev method
findlast(A::Union{AbstractArray, AbstractString}) = findprev(A, last(keys(A)))
findlast(A::AbstractArray) = findprev(A, last(keys(A)))

"""
findprev(predicate::Function, A, i)
Expand Down

2 comments on commit 3db0493

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here. cc @maleadt

Please sign in to comment.