Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
BLAS: avoid calling dlclose (#27509)
We do not want libblas to get unloaded again here, but we call this early enough, this is potentially the only reference to it. That may lead to race conditions where we try to teardown the library while it is trying to spawn threads (spawning threads is not generally permitted on Windows, but is down anyways by libopenblas.dll). So instead, we just cache our single reference to it, and thereby avoid the need to call `dlclose` to maintain the proper refcount.
- Loading branch information
2ba3fbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Executing the daily benchmark build, I will reply here when finished:
@nanosoldier
runbenchmarks(ALL, isdaily = true)
2ba3fbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan
2ba3fbb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the test for
atan2
needs to be updated (now deprecated toatan
) and the following were broken sometime since it last ran (vs = daily_2018_5_23):79486b3...2ba3fbb [173 commits]