spzeros tuple construction (#39886)

JuliaLang · Mar 3, 2021 · 21762f2 · 21762f2
1 parent 79d7683
commit 21762f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/stdlib/SparseArrays/src/sparsematrix.jl b/stdlib/SparseArrays/src/sparsematrix.jl
@@ -1674,10 +1674,12 @@ function spzeros(::Type{Tv}, ::Type{Ti}, m::Integer, n::Integer) where {Tv, Ti}
  ((m < 0) || (n < 0)) && throw(ArgumentError("invalid Array dimensions"))
  SparseMatrixCSC(m, n, fill(one(Ti), n+1), Vector{Ti}(), Vector{Tv}())
 end
-# de-splatting variant
+# de-splatting variants
 function spzeros(::Type{Tv}, ::Type{Ti}, sz::Tuple{Integer,Integer}) where {Tv, Ti}
  spzeros(Tv, Ti, sz[1], sz[2])
 end
+spzeros(::Type{Tv}, sz::Tuple{Integer,Integer}) where {Tv} = spzeros(Tv, Int, sz[1], sz[2])
+spzeros(sz::Tuple{Integer,Integer}) = spzeros(Float64, Int, sz[1], sz[2])
 
 import Base._one
 function Base._one(unit::T, S::AbstractSparseMatrixCSC) where T

diff --git a/stdlib/SparseArrays/test/sparse.jl b/stdlib/SparseArrays/test/sparse.jl
@@ -64,6 +64,9 @@ end
 
 @testset "spzeros de-splatting" begin
  @test spzeros(Float64, Int64, (2, 2)) == spzeros(Float64, Int64, 2, 2)
+ @test spzeros(Float64, Int32, (2, 2)) == spzeros(Float64, Int32, 2, 2)
+ @test spzeros(Float32, (3, 2)) == spzeros(Float32, Int, 3, 2)
+ @test spzeros((3, 2)) == spzeros((3, 2)...)
 end
 
 @testset "conversion to AbstractMatrix/SparseMatrix of same eltype" begin