make sure repeat does not allow negative inner and outer (#35525)

JuliaLang · Apr 23, 2020 · 20d1362 · 20d1362
1 parent 5a7cda9
commit 20d1362
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/base/abstractarraymath.jl b/base/abstractarraymath.jl
@@ -366,7 +366,13 @@ _rshps(shp, shp_i, sz, i, ::Tuple{}) =
 _reperr(s, n, N) = throw(ArgumentError("number of " * s * " repetitions " *
  "($n) cannot be less than number of dimensions of input ($N)"))
 
+_negreperr(n) = throw(ArgumentError("number of $n repetitions" *
+ "cannot be negative"))
+
 @noinline function _repeat(A::AbstractArray, inner, outer)
+ any(<(0), inner) && _negreperr("inner")
+ any(<(0), outer) && _negreperr("outer")
+
  shape, inner_shape = rep_shapes(A, inner, outer)
 
  R = similar(A, shape)

diff --git a/test/arrayops.jl b/test/arrayops.jl
@@ -936,6 +936,7 @@ end
  3 4], inner=(2,), outer=(2, 2))
  @test_throws ArgumentError repeat([1 2;
  3 4], inner=(2, 2), outer=(2,))
+ @test_throws ArgumentError repeat([1, 2], inner=(1, -1), outer=(1, -1))
 
  A = reshape(1:8, 2, 2, 2)
  R = repeat(A, inner = (1, 1, 2), outer = (1, 1, 1))