Skip to content

Commit

Permalink
pop! on unordered containers clarification. (#38097)
Browse files Browse the repository at this point in the history 
Updates the documentation as suggested by @timholy [here](https://discourse.julialang.org/t/why-does-delete-work-with-sets-but-not-deleteat/48596/10?u=henrique_becker). The text is provisional, the objective is to make clear the function also works on unordered containers and in such case the element removed is arbitrarily chosen.
  • Loading branch information
@henriquebecker91
henriquebecker91 committed Nov 3, 2020
1 parent 2af16f9 commit 1f9e8bd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion base/array.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1109,7 +1109,8 @@ end
pop!(collection) -> item
Remove an item in `collection` and return it. If `collection` is an
ordered container, the last item is returned.
ordered container, the last item is returned; for unordered containers,
an arbitrary element is returned.
# Examples
```jldoctest
Expand Down

10 comments on commit 1f9e8bd

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible issues were detected. A full report can be found here. cc @maleadt

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - successfully executed benchmarks. A full report can be found here. cc @christopher-dG

@maleadt
Copy link
Member

@maleadt maleadt commented on 1f9e8bd Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["Example"])

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no issues were detected. A full report can be found here. cc @maleadt

@maleadt
Copy link
Member

@maleadt maleadt commented on 1f9e8bd Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["Example"])

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no issues were detected. A full report can be found here. cc @maleadt

@maleadt
Copy link
Member

@maleadt maleadt commented on 1f9e8bd Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["Example"])

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no issues were detected. A full report can be found here. cc @maleadt

Please sign in to comment.