Skip to content

Commit

Permalink
don't create empty handler list when calling show_error_hints (#43733)
Browse files Browse the repository at this point in the history
  • Loading branch information
@aviatesk
aviatesk committed Jan 11, 2022
1 parent a7e4f6d commit 13b3e77
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion base/experimental.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,8 @@ the handler for that type.
This interface is experimental and subject to change or removal without notice.
"""
function show_error_hints(io, ex, args...)
hinters = get!(()->[], _hint_handlers, typeof(ex))
hinters = get(_hint_handlers, typeof(ex), nothing)
isnothing(hinters) && return
for handler in hinters
try
Base.invokelatest(handler, io, ex, args...)
Expand Down

15 comments on commit 13b3e77

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing some PkgEval development:

@nanosoldier runtests(["Example"], compiled = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong when running your job:

NanosoldierError: failed to run tests: MethodError: no method matching PkgEval.Configuration(::Bool; julia=v"1.8.0-DEV-13b3e77282e")
Closest candidates are:
  PkgEval.Configuration(::Any, !Matched::Any) at /storage/pkgeval/depot/packages/PkgEval/dQg00/src/run.jl:511 got unsupported keyword argument "julia"
  PkgEval.Configuration(; julia, compiled) at util.jl:453
  PkgEval.Configuration(!Matched::VersionNumber, !Matched::Bool) at /storage/pkgeval/depot/packages/PkgEval/dQg00/src/run.jl:511 got unsupported keyword argument "julia"

Logs and partial data can be found here
cc @maleadt

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["Example"], compiled = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no issues were detected. A full report can be found here.

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["Example"], compiled = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no issues were detected. A full report can be found here.

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanosoldier runtests(["Example"], vs = ":release-1.7", compiled = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - no new issues were detected. A full report can be found here.

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try the full thing:

@nanosoldier runtests(ALL, compiled = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible issues were detected. A full report can be found here.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Some of those reports don't have collapsible sections.
  2. Could we have a mode that compares compiled vs. non-compiled (on the same commit of Julia master), and prints the list of packages that passed on non-compiled but failed on compiled?

@maleadt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some of those reports don't have collapsible sections.

Actual failures are never collapsible, only the unchanged tests currently are.

  • Could we have a mode that compares compiled vs. non-compiled (on the same commit of Julia master), and prints the list of packages that passed on non-compiled but failed on compiled?

Yes, I realized that too upon seeing this report. I'll have a look today.

@DilumAluthge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual failures are never collapsible, only the unchanged tests currently are.

Oh, interesting. It kind of makes the report hard to navigate when there are 3000 failures, and you can't collapse any of them...

Please sign in to comment.