Skip to content

Commit

Permalink
shortcut if cycle detected in extension precompilation
Browse files Browse the repository at this point in the history
  • Loading branch information
IanButterworth committed Feb 9, 2024
1 parent 36b7d3b commit 0f075f1
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions base/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1392,6 +1392,13 @@ function run_extension_callbacks(pkgid::PkgId)
extids = pop!(EXT_DORMITORY, pkgid, nothing)
extids === nothing && return
for extid in extids
if in(extid.id, precompilation_stack) && !isprecompiled(extid.id)
@debug """
Dependency cycle detected in extension precompilation: $(join(precompilation_stack, " > ")) > $(extid.id.name)
$(extid.id) will not be loaded here.
"""
continue
end
if extid.ntriggers > 0
# indicate pkgid is loaded
extid.ntriggers -= 1
Expand Down

0 comments on commit 0f075f1

Please sign in to comment.