Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Pkg.add of non-github URL (fix #1546) #1548

Merged
merged 1 commit into from
Dec 30, 2019
Merged

fix Pkg.add of non-github URL (fix #1546) #1548

merged 1 commit into from
Dec 30, 2019

Conversation

StefanKarpinski
Copy link
Member

@omus, can you give this a try and see if it works for you?

@fredrikekre fredrikekre added this to the 1.4 milestone Dec 17, 2019
@StefanKarpinski
Copy link
Member Author

Bump...

@StefanKarpinski
Copy link
Member Author

Still waiting on confirmation of this fix.

@StefanKarpinski StefanKarpinski merged commit 9db07ef into master Dec 30, 2019
@StefanKarpinski StefanKarpinski deleted the sk/fix-non-github-url branch December 30, 2019 17:17
@KristofferC KristofferC mentioned this pull request Jan 3, 2020
Merged
28 tasks
@omus
Copy link
Member

omus commented Feb 4, 2020

Sorry I missed this. I can confirm it does fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omus omus Awaiting requested review from omus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@StefanKarpinski @omus @KristofferC @fredrikekre