Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag Mads.jl v0.4.5 #8916

Merged
merged 1 commit into from
Apr 21, 2017
Merged

Tag Mads.jl v0.4.5 #8916

merged 1 commit into from
Apr 21, 2017

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Apr 19, 2017

Repository: madsjulia/Mads.jl
Release: v0.4.5
Travis: Travis Build Status
Diff: vs v0.4.4
requires vs v0.4.4:

--- 0.4.4/requires
+++ 0.4.5/requires
@@ -18,7 +18,7 @@
 JSON
 JLD
 ProgressMeter
-Distributions
+Distributions 0.12.5
 DataStructures
 DataFrames
 StatsBase

cc: @montyvesselinov

JSON
JLD
ProgressMeter
Distributions 0.12.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't 0.12.3 work too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will. What is your suggestion? How we can ok 0.12.3 and 0.12.5+ but not 0.12.4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and several versions earlier than 0.12.3 worked too, right? do you know what the most recent feature you're relying on is? could say
Distributions 0.x.y 0.12.4 0.12.5 for some actual minimum 0.x.y, though expressing unions of ranges with gaps is a feature that I don't think anyone has made use of yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or pretend 0.12.4 didn't exist, since it would be slightly strange for someone to ask for a version with known bugs, and go back to not listing a version constraint

@montyvesselinov
Copy link
Contributor

montyvesselinov commented Apr 20, 2017 via email

@tkelman
Copy link
Contributor

tkelman commented Apr 20, 2017

the require format will likely be rewritten as part of https://github.com/JuliaLang/Juleps/blob/master/Pkg3.md

@montyvesselinov
Copy link
Contributor

montyvesselinov commented Apr 21, 2017 via email

@tkelman
Copy link
Contributor

tkelman commented Apr 21, 2017

Should we close this and only publish 0.4.6 then?

@montyvesselinov
Copy link
Contributor

montyvesselinov commented Apr 21, 2017 via email

@tkelman tkelman merged commit b5af5fb into JuliaLang:metadata-v2 Apr 21, 2017
@attobot attobot deleted the Mads/v0.4.5 branch April 21, 2017 21:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants