Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect_stdio (feature from v1.7) #801

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

MilesCranmer
Copy link
Sponsor Member

@MilesCranmer MilesCranmer commented Jul 17, 2023

From JuliaLang/julia#37978. This completely copies the code from that PR, with one fix for samefile -> Base.Filesystem.samefile. Unit tests are copied as well.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #801 (3ce84cb) into master (70ab162) will increase coverage by 0.84%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   91.69%   92.54%   +0.84%     
==========================================
  Files           2        2              
  Lines         265      295      +30     
==========================================
+ Hits          243      273      +30     
  Misses         22       22              
Impacted Files Coverage Δ
src/Compat.jl 93.06% <100.00%> (+0.85%) ⬆️

@MilesCranmer MilesCranmer changed the title Add redirect_stdin Add redirect_stdio Jul 17, 2023
@MilesCranmer MilesCranmer changed the title Add redirect_stdio Add redirect_stdio (feature from v1.7) Jul 17, 2023
@MilesCranmer
Copy link
Sponsor Member Author

Actually wait, I'm being an idiot. I should have just copied it in verbatim – the other functionality added has no effect on existing redirection.

@MilesCranmer
Copy link
Sponsor Member Author

Updated. Now it's a full copy of the code with everything working.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an entry in the README, but otherwise LGTM. (Also, feel free to bump the version.)

src/Compat.jl Outdated Show resolved Hide resolved
@MilesCranmer
Copy link
Sponsor Member Author

Done!

@martinholters martinholters merged commit cc4763c into JuliaLang:master Jul 25, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants