Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let muladd accept arrays #729

Merged
merged 12 commits into from
May 18, 2021
Merged

Let muladd accept arrays #729

merged 12 commits into from
May 18, 2021

Conversation

mcabbott
Copy link
Contributor

@mcabbott mcabbott commented Oct 29, 2020 •
edited
Loading

@mcabbott mcabbott marked this pull request as draft October 29, 2020 14:22
@simeonschaub
Copy link
Member

Don't we have a 5-arg mul! in Compat now? Couldn't we just use that for compatibility with all older versions?

@mcabbott
Copy link
Contributor Author

Yes we do, and I guess this uses it on early enough versions. But test failures earlier were from recursive dot issues.

@simeonschaub
Copy link
Member

Ah, I see!

@mcabbott mcabbott marked this pull request as ready for review October 29, 2020 16:31
@mcabbott mcabbott marked this pull request as draft October 30, 2020 17:06
martinholters
martinholters reviewed Nov 2, 2020
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
@mcabbott mcabbott marked this pull request as ready for review November 20, 2020 10:37
@mcabbott
Copy link
Contributor Author

Test failure on MacOS nightly looks to be that it has a too-old nightly, it passes locally.

It might be possible to make the definitions here work on nightly versions between the two PRs above, but won't be easy to avoid ambiguities, and that doesn't seem like a great use of time.

@mcabbott mcabbott mentioned this pull request Nov 20, 2020
Closed
@mcabbott mcabbott closed this Nov 21, 2020
@mcabbott mcabbott reopened this Nov 21, 2020
@mcabbott mcabbott closed this Nov 28, 2020
@mcabbott mcabbott reopened this Nov 28, 2020
@mcabbott mcabbott closed this Nov 28, 2020
@mcabbott
Copy link
Contributor Author

mcabbott commented Nov 28, 2020 •
edited
Loading

(Sorry about the noise! Was trying to re-trigger travis. But it seems to be out of credit, in fact.)

@mcabbott mcabbott reopened this Nov 28, 2020
@mcabbott
Copy link
Contributor Author

Bump? CI looks happy, tests pass locally on 1.3, 1.4, 1.5.

@oxinabox
Copy link
Contributor

Bump

omus
omus requested changes Jan 11, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
omus
omus reviewed Jan 11, 2021
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
@simeonschaub simeonschaub requested a review from omus April 27, 2021 07:59
simeonschaub
simeonschaub reviewed Apr 27, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
simeonschaub
simeonschaub approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #729 (46515c0) into master (61726a3) will increase coverage by 0.70%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
+ Coverage   80.64%   81.34%   +0.70%     
==========================================
  Files           4        4              
  Lines         465      504      +39     
==========================================
+ Hits          375      410      +35     
- Misses         90       94       +4
Impacted Files Coverage Δ
src/Compat.jl 81.44% <89.74%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61726a3...46515c0. Read the comment docs.

mcabbott
mcabbott commented Apr 27, 2021
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
omus
omus approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after CI passes

@omus omus merged commit f6d766c into JuliaLang:master May 18, 2021
@mcabbott mcabbott deleted the muladd branch May 18, 2021 14:53
This was referenced May 19, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinholters martinholters martinholters left review comments

@omus omus omus approved these changes

@simeonschaub simeonschaub simeonschaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mcabbott @simeonschaub @oxinabox @codecov-commenter @omus @martinholters