Backport ComposedFunction #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would we want to add the constructors, too? It's a bit tricky, but something along these lines would work: @eval ComposedFunction{F,G}(f,g) where {F,G} = $(Expr(:new, :(ComposedFunction{F,G}), :f, :g))
parentmodule(typeof(h)).eval(:($(nameof(typeof(h)))(f::F, g::G) where {F,G} = $(nameof(typeof(h))){F,G}(f,g))) |
tkf
commented
Sep 11, 2020
Co-authored-by: Martin Holters <[email protected]>
jw3126
reviewed
Sep 24, 2020
tkf
commented
Sep 24, 2020
| @@ -607,6 +607,37 @@ if VERSION < v"1.5.0-DEV.438" # 0a43c0f1d21ce9c647c49111d93927369cd20f85 | |||
| Base.startswith(s) = Base.Fix2(startswith, s) | |||
| end | |||
|
|
|||
| # https://github.com/JuliaLang/julia/pull/37517 | |||
| if VERSION < v"1.6.0-DEV.1037" | |||
| export ComposedFunction | |||
There was a problem hiding this comment.
I added export since Base now exports ComposedFunction: JuliaLang/julia#37517 (comment)
jw3126
reviewed
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest adding
Compat.ComposedFunctionwhen/if JuliaLang/julia#37517 is merged. This way, individual packages like DataFrames.jl don't have to implement the same hack.