Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to be agnostic to type printing #183

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

goretkin
Copy link
Contributor

@goretkin goretkin commented Sep 8, 2020

JuliaLang/julia#37085 changed how type parameters
are printed, causing the following error:

Borders (issue #85): Test Failed at /home/runner/work/ImageFiltering.jl/ImageFiltering.jl/test/2d.jl:337
  Expression: imfilter(A, kern, Fill(0, (3,)))
    Expected: ArgumentError("Fill{Int64,1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions")
      Thrown: ArgumentError("Fill{Int64, 1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions")

See https://github.com/JuliaImages/ImageFiltering.jl/runs/1053929388?check_suite_focus=true#step:5:273 for the CI failure.

JuliaLang/julia#37085 changed how type parameters
are printed, causing the following error:

```
Borders (issue JuliaImages#85): Test Failed at /home/runner/work/ImageFiltering.jl/ImageFiltering.jl/test/2d.jl:337
  Expression: imfilter(A, kern, Fill(0, (3,)))
    Expected: ArgumentError("Fill{Int64,1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions")
      Thrown: ArgumentError("Fill{Int64, 1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions")
```
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   77.60%   77.60%           
=======================================
  Files           9        9           
  Lines         978      978           
=======================================
  Hits          759      759           
  Misses        219      219           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c0ea6b...7f88cca. Read the comment docs.

@johnnychen94
Copy link
Member

Let's first check if it is stilling working wrt #182

@johnnychen94 johnnychen94 reopened this Sep 8, 2020
@goretkin
Copy link
Contributor Author

goretkin commented Sep 8, 2020

Did closing and opening trigger the CI? I wasn't sure why it didn't run to begin with.

@johnnychen94
Copy link
Member

I disabled the fail-fast option 1172657 so that even if there's a test failure in nightly build, others are still running; a close and reopen would build the CI in the new master base.

@johnnychen94
Copy link
Member

A similar ambiguity issue is found in JuliaArrays/OffsetArrays.jl#139 I'll go check it first this weekend and then revisit this PR.

@timholy
Copy link
Member

timholy commented Sep 8, 2020

The ambiguity issue might be changed or reverted; see JuliaLang/julia#36962 (comment). I'm sitting pat for a while in my other repos, or just transiently disabling the ambiguity test.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnnychen94, if this looks good to you please merge.

@johnnychen94 johnnychen94 merged commit 3609921 into JuliaImages:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants