Expand DatasetAccessProperties coverage, add helpers #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only missing dataset access property is This has a signature unlike the others. |
julia> dapl = HDF5.init!(HDF5.DatasetAccessProperties())
HDF5.DatasetAccessProperties(
chunk_cache = (nslots = 0x0000000000000209, nbytes = 0x0000000000100000, w0 = 0.75),
efile_prefix = "",
virtual_prefix = "",
virtual_printf_gap = 0x0000000000000000,
virtual_view = :last_available,
) |
musm
reviewed
Jun 6, 2022
src/api/helpers.jl
Outdated
| @@ -411,6 +419,11 @@ function h5p_get_efile_prefix(plist) | |||
| return String(buffer) | |||
| end | |||
|
|
|||
| function h5p_set_efile_prefix(plist, sym::Symbol) | |||
| sym === :origin ? h5p_set_efile_prefix(plist, raw"$ORIGIN") : | |||
| error("The only valid symbol for h5p_set_efile_prefix is :origin.") | |||
musm
reviewed
Jun 6, 2022
mkitti
commented
Jun 6, 2022
|
This should be good to go for now. I think |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded
DatasetAccessPropertiesto coverchunk_cache: Chunk cache parameters as (nslots, nbytes, w0).Default: (521, 0x100000, 0.75)
efile_prefix: Path prefix for reading external files.The default is the current working directory.
:origin: alias forraw"\$ORIGIN"will make the external file relative tothe HDF5 file.
virtual_prefix: Path prefix for reading virtual datasets.virtual_printf_gap: The maximum number of missing source files and/ordatasets with the printf-style names when getting the extent of an unlimited
virtual dataset
virtual_view: Influences whether the view of the virtual dataset includesor excludes missing mapped elements
:first_missing: includes all data before the first missing mapped data:last_available: includes all available mapped dataPending tasks: