Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Cstring in ccall #1056

Merged
merged 1 commit into from
Feb 23, 2023
Merged

use Cstring in ccall #1056

merged 1 commit into from
Feb 23, 2023

Conversation

simonbyrne
Copy link
Collaborator

@simonbyrne simonbyrne commented Feb 23, 2023 •
edited

Fixes #1055

I've changed all the cases where we pass an input string, but kept unchanged the cases where it is for an output buffer.

@mkitti
Copy link
Member

mkitti commented Feb 23, 2023

Why would h5l_iterate not propagate an assertion error now?

@simonbyrne
Copy link
Collaborator Author

What are you referring to?

@mkitti
Copy link
Member

mkitti commented Feb 23, 2023

In https://github.com/JuliaIO/HDF5.jl/actions/runs/4255902935/jobs/7404107933 there was a stochastic failure. I reran it and now its gone... ?

mkitti
mkitti approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@mkitti mkitti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Keeping an eye out for the h5l_iterate test issue.

@simonbyrne simonbyrne merged commit 9b4fcde into master Feb 23, 2023
@simonbyrne simonbyrne deleted the sb/cstring branch February 23, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkitti mkitti mkitti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected create_group key from readdlm string data
2 participants
@simonbyrne @mkitti