Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct docs on JULIA_HDF5_PATH search path #1032

Merged
merged 1 commit into from
Jan 13, 2023
Merged

correct docs on JULIA_HDF5_PATH search path #1032

merged 1 commit into from
Jan 13, 2023

Conversation

stevengj
Copy link
Member

The docs say that it searches $JULIA_HDF5_PATH/lib and $JULIA_HDF5_PATH/lib64 for the libraries, but according to the code it also searches $JULIA_HDF5_PATH directly.

@mkitti
Copy link
Member

mkitti commented Jan 13, 2023

I'm ok with merging this, but I think we should probably deprecate this mechanism in favor of the Preferences.jl based JLL override mechanism. One could then either override the location via Overrides.toml in the Julia depot or LocalPreferences.toml in the project directory.

@musm musm merged commit 6a3ee06 into master Jan 13, 2023
@musm musm deleted the stevengj-patch-1 branch January 13, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants