Skip to content

Commit

Permalink
Windows SZIP support now fixed
Browse files Browse the repository at this point in the history 
Closes #1106
  • Loading branch information
@simonbyrne
simonbyrne committed Sep 7, 2023
1 parent 6afbafb commit 93c6cce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/filter.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ using HDF5.Filters: ExternalFilter, isavailable, isencoderenabled, isdecoderenab
@test HDF5.API.h5z_filter_avail(HDF5.API.H5Z_FILTER_SCALEOFFSET)
@test HDF5.API.h5z_filter_avail(HDF5.API.H5Z_FILTER_SHUFFLE)
if !Preferences.has_preference(HDF5, "libhdf5")
if HDF5.API.h5_get_libversion() < v"1.14" || Sys.iswindows()
if HDF5.API.h5_get_libversion() < v"1.14"
@test_broken HDF5.API.h5z_filter_avail(HDF5.API.H5Z_FILTER_SZIP)
else
@test HDF5.API.h5z_filter_avail(HDF5.API.H5Z_FILTER_SZIP)
Expand Down

3 comments on commit 93c6cce

@mkitti
Copy link
Member

@mkitti mkitti commented on 93c6cce Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Was this a commit directly to master?

@simonbyrne
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant to open a PR, but accidentally committed. (probably should enable branch protection)

@mkitti
Copy link
Member

@mkitti mkitti commented on 93c6cce Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled branch protection.

Please sign in to comment.