Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out-of-place copy method for JP #108

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Out-of-place copy method for JP #108

merged 10 commits into from
Jun 11, 2024

Conversation

aelligp
Copy link
Collaborator

@aelligp aelligp commented Jun 7, 2024

Similar to the version of JustRelax.
Usage:

 particles = init_particle(
        backend, nxcell, max_xcell, min_xcell, xvi...
    )
particles_o = copy(particles)

albert-de-montserrat
albert-de-montserrat requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@albert-de-montserrat albert-de-montserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But could you add a couple of tests?

@albert-de-montserrat albert-de-montserrat merged commit 8065438 into main Jun 11, 2024
9 of 11 checks passed
@albert-de-montserrat albert-de-montserrat deleted the pa-copy branch June 11, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albert-de-montserrat albert-de-montserrat albert-de-montserrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aelligp @albert-de-montserrat