Refactor CUSPARSE #409
Merged
Refactor CUSPARSE #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
bugfix
- wrap cusparseSpMM - make the cusparseSpMV wrapper support CSC - switch to 5-arg mul
maleadt
force-pushed
the
tb/sparse_mm_mv
branch
from
e113713
to
e39398f
Compare
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
- Coverage 78.90% 78.77% -0.13%
==========================================
Files 166 166
Lines 8756 8783 +27
==========================================
+ Hits 6909 6919 +10
- Misses 1847 1864 +17
Continue to review full report at Codecov.
|
maleadt
changed the title
We have multiple sparse array types, so hard to choose one.
|
This turned out pretty breaking, removing some idiosyncrasies and replacing them with more standard interfaces (e.g. replace all the switch2xxx functions with constructors), but I think it's for the better. Will make sure next release is a breaking one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most of #322. Not perfect yet, but it should get us back to where we were.
Closes #98, #113, #146, #216