Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Julia wrappers for CUDA v12.5 #2396

Merged
merged 1 commit into from
May 27, 2024
Merged

Update Julia wrappers for CUDA v12.5 #2396

merged 1 commit into from
May 27, 2024

Conversation

amontoison
Copy link
Member

No description provided.

maleadt
maleadt requested changes May 25, 2024
View reviewed changes
Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have realized the wrapper bump in my PR didn't had enough changes...

res/wrap/Manifest.toml Outdated Show resolved Hide resolved
lib/cudadrv/libcuda.jl Show resolved Hide resolved
@amontoison
Copy link
Member Author

The tests are failing because of NVML_STRUCT_VERSION.
I will update nvml.toml to add additional constants here.

@amontoison
Copy link
Member Author

Tests only passed on Julia 1.9.
It's already the case on master.
I don't know if we have additional errors with this PR.

@maleadt maleadt added enhancement New feature or request cuda libraries Stuff about CUDA library wrappers. labels May 27, 2024
@maleadt maleadt merged commit e73e8a2 into JuliaGPU:master May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt approved these changes

Assignees
No one assigned
Labels
cuda libraries Stuff about CUDA library wrappers. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amontoison @maleadt