Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enzyme: support fill #2371

Merged
merged 5 commits into from
May 14, 2024
Merged

Enzyme: support fill #2371

merged 5 commits into from
May 14, 2024

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented May 12, 2024

No description provided.

@wsmoses
Copy link
Contributor Author

wsmoses commented May 13, 2024

@vchuravy could this get a review, it's blocking some ML users

@maleadt maleadt marked this pull request as draft May 13, 2024 20:24
@maleadt
Copy link
Member

maleadt commented May 13, 2024

Let's mark this as draft to save on CI resources until tests initially pass.

@maleadt maleadt added the extensions Stuff about package extensions. label May 13, 2024
@wsmoses
Copy link
Contributor Author

wsmoses commented May 13, 2024

@maleadt okay I fixed the minor typos that hopefully should let it pass.

Assuming it passes, does it look good to you?

@maleadt maleadt marked this pull request as ready for review May 14, 2024 11:35
@maleadt
Copy link
Member

maleadt commented May 14, 2024

Assuming it passes, does it look good to you?

I'm unfamiliar with Enzyme, so I can't say much about the change.

The fact that it's very Enzyme specific (while using CUDA.jl-internals that are likely to break) actually makes me somewhat uncomfortable carrying this in CUDA.jl, even as a package extension, but as long as you and @vchuravy are happy to maintain it I guess it's fine to have (and test) this functionality...

@wsmoses
Copy link
Contributor Author

wsmoses commented May 14, 2024

yeah we commit to maintaining. And yeah that's why I think it makes most sense as an extension here (since it can follow cuda.jl internal changes correctly), since the enzymerules API is intentionally stable.

@maleadt maleadt merged commit a9434ac into JuliaGPU:master May 14, 2024
1 check passed
wsmoses added a commit to wsmoses/CUDA.jl that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Stuff about package extensions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants