Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enzyme: Forward mode sync #2369

Merged
merged 4 commits into from
May 14, 2024
Merged

Enzyme: Forward mode sync #2369

merged 4 commits into from
May 14, 2024

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented May 11, 2024

@wsmoses wsmoses changed the title Forward mode sync Enzyme: Forward mode sync May 12, 2024
@vchuravy
Copy link
Member

Error in testset libraries/enzyme:
Test Failed at /var/lib/buildkite-agent/builds/gpuci-16/julialang/cuda-dot-jl/test/libraries/enzyme.jl:27
  Expression: all(dA .≈ 2:2:128)
Error in testset libraries/enzyme:
Error During Test at /var/lib/buildkite-agent/builds/gpuci-16/julialang/cuda-dot-jl/test/setup.jl:62
  Got exception outside of a @test
  LoadError: UndefVarError: batch_width not defined
  Stacktrace:

@maleadt maleadt marked this pull request as draft May 13, 2024 20:24
@maleadt
Copy link
Member

maleadt commented May 13, 2024

Let's mark this as draft to save on CI resources until tests initially pass.

@maleadt maleadt added the extensions Stuff about package extensions. label May 13, 2024
@wsmoses
Copy link
Contributor Author

wsmoses commented May 13, 2024

@maleadt okay I fixed the minor typos that hopefully should let it pass.

Assuming it passes, does it look good to you?

@maleadt maleadt marked this pull request as ready for review May 14, 2024 13:13
@maleadt maleadt merged commit 863c4e0 into JuliaGPU:master May 14, 2024
1 check passed
@wsmoses wsmoses deleted the fwdsync branch May 14, 2024 15:17
@wsmoses
Copy link
Contributor Author

wsmoses commented May 14, 2024

@maleadt admittedly this is a bit greedy of a request, but would it be possible to release (perhaps via backport since I know you're working on some breaking changes) the current EnzymeCUDA functionality.

This in particular is needed to re-fix KA+Enzyme CI [and other downstream ML users would like].

@maleadt
Copy link
Member

maleadt commented May 14, 2024

I'd rather let the master branch bake for a while more. Can you create a PR against https://github.com/JuliaGPU/CUDA.jl/tree/release-5.3 with the commits (git cherry-pick ...) you need?

wsmoses added a commit to wsmoses/CUDA.jl that referenced this pull request May 14, 2024
@maleadt
Copy link
Member

maleadt commented May 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Stuff about package extensions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants