Mark cublas version/handle as non-differentiable #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
approved these changes
May 9, 2024
|
It needed one for the other PR to ensure unified memory setup is fine |
|
@vchuravy can you merge? |
Yes, but there is a question how we test this code. |
|
Yeah I have a test [just doing CUBLAS.Dot(x, y) but that presently fails for the reason of cudamemset as a fn not being found so we need to figure out the correct symbol materialization story. Still helpful for reducing error before then tho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on getting a minimal working cublas AD working, but these are nevertheless prerequisites that will reduce the error log size for a lot of users already (e.g. EnzymeAD/Enzyme.jl#1392)