Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the currect memory type when wrapping system memory. #2363

Merged
merged 1 commit into from
May 7, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 7, 2024

This depends on the system: If HMM is supported, use unified memory, otherwise register the buffer as host memory.

@maleadt maleadt added enhancement New feature or request cuda array Stuff about CuArray. labels May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.78%. Comparing base (c423ce3) to head (92b40df).

Files Patch % Lines
src/array.jl 80.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2363       +/-   ##
===========================================
+ Coverage   59.88%   72.78%   +12.89%     
===========================================
  Files         157      157               
  Lines       15109    15148       +39     
===========================================
+ Hits         9048    11025     +1977     
+ Misses       6061     4123     -1938     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit cdd8078 into master May 7, 2024
1 check passed
@maleadt maleadt deleted the tb/unsafe_wrap branch May 7, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda array Stuff about CuArray. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant