Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle cache improvements #2352

Merged
merged 7 commits into from
Apr 27, 2024
Merged

Handle cache improvements #2352

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c135ba4
Register handle ctor/dtors with the cache.
maleadt Apr 26, 2024
da3b6f9
Collect memory before allocating library handles.
maleadt Apr 26, 2024
b132113
Introduce reclaim hooks to wipe the handle cache.
maleadt Apr 26, 2024
e41d35b
Reduce scope of critical section.
maleadt Apr 26, 2024
a580528
Use a finalizer-safe lock.
maleadt Apr 26, 2024
eb5f0c3
Skip invalid contexts in dtors.
maleadt Apr 26, 2024
49a0183
Restrict subpackage compatibility.
maleadt Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Collect memory before allocating library handles.
  • Loading branch information
@maleadt
maleadt committed Apr 27, 2024
commit da3b6f9b16d6dffa1598777780a37efcea57d191
1 change: 1 addition & 0 deletions lib/utils/cache.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ function Base.pop!(cache::HandleCache{K,V}, key::K) where {K,V}
# we could (and used to) run `GC.gc(false)` here to free up old handles,
# but that can be expensive when using lots of short-lived tasks.
if handle === nothing
CUDA.maybe_collect()
handle = cache.ctor(key)
end

Expand Down