Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUSOLVER] Fix the dispatch for syevd! and heevd! #2309

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[CUSOLVER] Fix the dispatch for syevd! and heevd! #2309

merged 1 commit into from
Apr 16, 2024

Conversation

amontoison
Copy link
Member

No description provided.

@amontoison amontoison changed the title [CUSOLVER] Fix the dispatch for syevd! end heevd! [CUSOLVER] Fix the dispatch for syevd! and heevd! Apr 1, 2024
@maleadt
Copy link
Member

maleadt commented Apr 1, 2024

LGTM.

Tangentially, I only noticed now you added LinearAlgebra.LAPACK implementations in #1806. There's no guarantee that CUSOLVER exactly implements the LAPACK interface (that's what drop-in libraries like NVBLAS are for), so I'd rather the interface be just CUSOLVER.syev! etc for the low-level wrappers, and LinearAlgebra interfaces (not LinearAlgebra.LAPACK) as the generic interface.

@maleadt maleadt added bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers. labels Apr 16, 2024
@maleadt maleadt merged commit 545ffa2 into JuliaGPU:master Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This gets something working again. cuda libraries Stuff about CUDA library wrappers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amontoison @maleadt