Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid constructing MulAddMuls on Julia v1.12+ #2277

Merged
merged 2 commits into from
May 23, 2024

Conversation

dkarrasch
Copy link
Contributor

This is a companion PR to JuliaLang/julia#52439. Basically, it avoids the construction of MulAddMuls and simply passes the factors alpha and beta forward.

@dkarrasch
Copy link
Contributor Author

I changed things such that there are two methods of each signature type: first a legacy method, that has MulAddMuls in their final argument. Those get destructured and the call is forward to the second method, that has alpha, beta in their final places. On older versions, the pathway is via the first one, on upcoming versions after the above mentioned PR is merged, the second method will simply overload the upstream generic_matmatmul! and step in the place of the first method directly in the call chain. Altogether, this should be non-breaking, so if tests pass, this could be merged and released, and then we see how it goes on current Julia master.

@maleadt maleadt marked this pull request as draft March 21, 2024 08:48
@maleadt maleadt marked this pull request as ready for review May 23, 2024 07:55
@maleadt
Copy link
Member

maleadt commented May 23, 2024

Thanks!

@maleadt maleadt merged commit cbbf19a into JuliaGPU:master May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants