Reduce locking in the handle cache #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the size of the critical section, and don't call the GC if we didn't find a handle.
maleadt
added
enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2256 +/- ##
==========================================
- Coverage 71.34% 71.33% -0.01%
==========================================
Files 155 155
Lines 14858 14859 +1
==========================================
Hits 10600 10600
- Misses 4258 4259 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also don't call the GC, it may cause trashing when using many short-lived tasks.
cc @kshyatt