Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly rework error handling #2245

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Slightly rework error handling #2245

merged 4 commits into from
Jan 19, 2024

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 19, 2024

  • simplify some of the custom error detection routines, now just always retrying API calls if they hit alloc_fail|init_fail|internal
  • in already expensive call chains, use try/catch to preserve the failing API call
  • simplify retry_reclaim a bit, halving the overhead it imposes
  • add launch failure diagnostics

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (d4b766b) 71.36% compared to head (41dcc90) 71.32%.
Report is 1 commits behind head on master.

Files Patch % Lines
lib/cudadrv/module/linker.jl 61.90% 8 Missing ⚠️
lib/cublas/wrappers.jl 25.00% 6 Missing ⚠️
src/pool.jl 81.81% 6 Missing ⚠️
lib/cudadrv/execution.jl 82.60% 4 Missing ⚠️
lib/cudadrv/module.jl 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
- Coverage   71.36%   71.32%   -0.05%     
==========================================
  Files         156      155       -1     
  Lines       14820    14837      +17     
==========================================
+ Hits        10577    10582       +5     
- Misses       4243     4255      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit d8c6d6d into master Jan 19, 2024
1 check passed
@maleadt maleadt deleted the tb/error_handling branch January 19, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant