Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for new CUQUANTUM #2210

Merged
merged 9 commits into from
Jan 12, 2024
Merged

Updates for new CUQUANTUM #2210

merged 9 commits into from
Jan 12, 2024

Conversation

kshyatt
Copy link
Contributor

@kshyatt kshyatt commented Dec 27, 2023

No description provided.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 461 lines in your changes are missing coverage. Please review.

Comparison is base (e718b0d) 72.76% compared to head (a1d18d2) 60.71%.
Report is 1 commits behind head on master.

❗ Current head a1d18d2 differs from pull request most recent head 93c01b8. Consider uploading reports for the commit 93c01b8 to get more accurate results

Files Patch % Lines
lib/cutensornet/src/libcutensornet.jl 0.00% 118 Missing ⚠️
lib/cutensor/src/types.jl 0.00% 84 Missing ⚠️
lib/custatevec/src/libcustatevec.jl 0.00% 73 Missing ⚠️
lib/cutensor/src/libcutensor.jl 0.00% 73 Missing ⚠️
lib/cutensor/src/operations.jl 0.00% 53 Missing ⚠️
lib/custatevec/src/statevec.jl 0.00% 36 Missing ⚠️
lib/cutensor/src/utils.jl 0.00% 15 Missing ⚠️
lib/custatevec/src/types.jl 0.00% 8 Missing ⚠️
lib/cutensor/src/cuTENSOR.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2210       +/-   ##
===========================================
- Coverage   72.76%   60.71%   -12.05%     
===========================================
  Files         159      155        -4     
  Lines       14775    14315      -460     
===========================================
- Hits        10751     8692     -2059     
- Misses       4024     5623     +1599     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt changed the base branch from master to tb/cutensor2 January 2, 2024 08:17
@maleadt
Copy link
Member

maleadt commented Jan 2, 2024

Changed the base branch, and rebased.

@maleadt maleadt force-pushed the tb/cutensor2 branch 4 times, most recently from 0015e38 to 82ca4ce Compare January 9, 2024 11:26
Base automatically changed from tb/cutensor2 to master January 11, 2024 16:18
@maleadt
Copy link
Member

maleadt commented Jan 11, 2024

Rebased & unmarking as draft in order to run subpackage CI.

@kshyatt What needs to happen for this to get merged?

FYI, NVIDIA told me that cuQuantum isn't expected to support cuTENSOR 2.0 for at least a while still.

@maleadt maleadt marked this pull request as ready for review January 11, 2024 16:25
@maleadt
Copy link
Member

maleadt commented Jan 12, 2024

@kshyatt cutensornetTensorQualifiers_t has new fields now, isConstant and requiresGradient. I've kept the API for now (only passing in isConjugate as an Int32), so you may want to change this depending on your use case.

@maleadt maleadt merged commit 2b97ab2 into master Jan 12, 2024
1 check was pending
@maleadt maleadt deleted the ksh/cuquantum branch January 12, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants