Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Random.jl seeding for 1.11 #2199

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

IanButterworth
Copy link
Contributor

Fixes #2198

This precompiles locally on

julia> versioninfo()
Julia Version 1.11.0-DEV.1078
Commit b71523e9b8 (2023-12-11 17:36 UTC)
Platform Info:
  OS: macOS (arm64-apple-darwin23.0.0)
  CPU: 10 × Apple M2 Pro
  WORD_SIZE: 64
  LLVM: libLLVM-15.0.7 (ORCJIT, apple-m1)
  Threads: 1 on 6 virtual cores

@maleadt
Copy link
Member

maleadt commented Dec 12, 2023

Thanks, but just disabling code to get the package to precompile isn't a good fix; this breaks seeding the (global implicit) RNG from kernels. I'd rather have a hard failure to make clear what's broken instead of silent corruption.

@maleadt maleadt changed the title Fix for julia 1.11 latest Fix Random.jl seeding for 1.11 Dec 12, 2023
@maleadt maleadt marked this pull request as draft December 12, 2023 09:15
@maleadt maleadt marked this pull request as ready for review December 12, 2023 12:25
@maleadt maleadt merged commit 6873997 into JuliaGPU:master Dec 12, 2023
1 check passed
maleadt added a commit that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest julia: UndefVarError: make_seed not defined in Random
2 participants