Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the structures ILU0Info() and IC0Info() for the preconditioners #2187

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

amontoison
Copy link
Member

The internal structure that contains the info during the computation of the preconditioner was not destroyed if a null pivot was encountered.
For CSC / CSR formats, I added structures such that we don't take care of that.
For BSR format, I destroy the structure if a null pivot is encountered, I didn't added structures because we don't use often this format...

@maleadt
Copy link
Member

maleadt commented Dec 5, 2023

I wonder if we should introduce syntax for this, that would allow for automatic scoped destruction (a la defer) instead of relying on the garbage collector. Maybe even just using Defer.jl? Could be done in a later PR.

For BSR format, I destroy the structure if a null pivot is encountered, I didn't added structures because we don't use often this format...

I'd prefer if we act consistently for all cases, if only to make it easier to refactor this code if e.g. switching to a Defer.jl-like mechanism.

@maleadt maleadt merged commit 4f29369 into JuliaGPU:master Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants