Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call into LLVM's fmin/fmax on <sm_80. #2154

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Don't call into LLVM's fmin/fmax on <sm_80. #2154

merged 4 commits into from
Nov 6, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Nov 6, 2023

Fixes #2148

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (301318e) 72.17% compared to head (cee7722) 72.18%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2154      +/-   ##
==========================================
+ Coverage   72.17%   72.18%   +0.01%     
==========================================
  Files         159      159              
  Lines       14485    14487       +2     
==========================================
+ Hits        10455    10458       +3     
+ Misses       4030     4029       -1     
Files Coverage Δ
src/compiler/compilation.jl 95.53% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit daf0ff0 into master Nov 6, 2023
1 check passed
@maleadt maleadt deleted the tb/fminmax branch November 6, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LLVM generates max.NaN which only works on sm_80
1 participant