Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle and test zero-size inputs to RNGs. #2098

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Handle and test zero-size inputs to RNGs. #2098

merged 1 commit into from
Sep 26, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Sep 26, 2023

Fixes #2093

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (43370c5) 71.73% compared to head (ac017e9) 71.72%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2098      +/-   ##
==========================================
- Coverage   71.73%   71.72%   -0.01%     
==========================================
  Files         157      157              
  Lines       13853    13867      +14     
==========================================
+ Hits         9937     9946       +9     
- Misses       3916     3921       +5     
Files Coverage Δ
src/random.jl 63.84% <100.00%> (+0.41%) ⬆️
lib/curand/random.jl 72.65% <69.23%> (-0.62%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit 60a21ae into master Sep 26, 2023
1 check passed
@maleadt maleadt deleted the tb/empty_rand branch September 26, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA.rand(Int64, m, n) can not be used when m or n is zero
1 participant