Add a method inv(CuMatrix) #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontoison
commented
Sep 25, 2023
| n = checksquare(A) | ||
| F = copy(A) | ||
| factors, ipiv, info = getrf!(F) | ||
| B = CuMatrix{T}(I, n, n) |
There was a problem hiding this comment.
@maleadt Do you know a better way to create an identity matrix of size n with CUDA.jl?
There was a problem hiding this comment.
This looks fine, and is specialized in GPUArrays. We could avoid a kernel to set the diagonal by using a 2D memcpy, but looking at the profiler most of the time is spent during the zero initialization, so there's not much to gain.
|
CUSOLVER also has an optimized routine to directly invert triangular matrices (trtri). I started to interface it here. |
maleadt
added
enhancement
|
Thanks! This has been often requested, so is great to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.