Rework and extend the cooperative groups API. #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2081 +/- ##
=======================================
Coverage 72.01% 72.01%
=======================================
Files 158 158
Lines 14252 14251 -1
=======================================
Hits 10263 10263
+ Misses 3989 3988 -1
☔ View full report in Codecov by Sentry. |
maleadt
changed the title
maleadt
force-pushed
the
tb/cg
branch
3 times, most recently
from
2d89da3
to
762d568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings it much closer to the upstream API. It should be good to use more widely, especially because it looks like
@cuda cooperative=trueis only needed for grid synchronization.Includes the implicit groups (thread blocks, grid groups, coalesced groups), shuffle, and async memcpy. What remains are the explicitly created groups (i.e., tiling and partitioning).