Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sortperm! resilient to type mismatches. #2051

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Aug 21, 2023

Fixes #2046

@maleadt maleadt added cuda array Stuff about CuArray. bugfix This gets something working again. labels Aug 21, 2023
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.08% ⚠️

Comparison is base (cb231f5) 70.96% compared to head (cff31d4) 70.89%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
- Coverage   70.96%   70.89%   -0.08%     
==========================================
  Files         157      157              
  Lines       13825    13824       -1     
==========================================
- Hits         9811     9800      -11     
- Misses       4014     4024      +10     
Files Changed Coverage Δ
src/sorting.jl 23.40% <100.00%> (-0.18%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit c0f0df3 into master Aug 21, 2023
1 check passed
@maleadt maleadt deleted the tb/sortperm_mismatch branch August 21, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This gets something working again. cuda array Stuff about CuArray.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sortperm! fails when output is UInt vector
1 participant