Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Adapt" to "1.1" #201

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 4, 2020

This pull request changes the compat entry for the Adapt package from 2.0 to 2.0, 1.1.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #201 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
- Coverage   82.27%   81.99%   -0.29%     
==========================================
  Files         143      143              
  Lines        9283     9332      +49     
==========================================
+ Hits         7638     7652      +14     
- Misses       1645     1680      +35     
Impacted Files Coverage Δ
examples/wmma/high-level.jl 11.11% <0.00%> (-38.89%) ⬇️
examples/wmma/low-level.jl 14.28% <0.00%> (-35.72%) ⬇️
test/device/wmma.jl 0.00% <0.00%> (-7.41%) ⬇️
test/execution.jl 38.68% <0.00%> (-1.47%) ⬇️
test/device/cuda.jl 9.72% <0.00%> (-0.73%) ⬇️
test/runtests.jl 60.68% <0.00%> (+11.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfef6d7...f47b664. Read the comment docs.

@maleadt
Copy link
Member

maleadt commented Jun 4, 2020

don't merge. invalid. the tool is confused because Adapt 2.0 hasn't been released.

@maleadt maleadt closed this Jun 10, 2020
@maleadt maleadt deleted the compathelper/new_version/2020-06-04-00-25-15-136-1801387408 branch June 10, 2020 20:21
@maleadt maleadt added the dependencies About things we use. label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies About things we use.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant