Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some performance tips to the documentation #1999

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

Zentrik
Copy link
Contributor

@Zentrik Zentrik commented Jul 13, 2023

Adds a tutorial containing some julia specific performance optimisations and some resources for more information.

@Zentrik Zentrik marked this pull request as draft July 13, 2023 15:21
@Zentrik
Copy link
Contributor Author

Zentrik commented Jul 13, 2023

I left this as a draft just to skip the CI suite.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that will be a great addition to the docs!

docs/src/tutorials/performance.jl Outdated Show resolved Hide resolved
docs/src/tutorials/performance.jl Outdated Show resolved Hide resolved
docs/src/tutorials/performance.jl Outdated Show resolved Hide resolved
@maleadt
Copy link
Member

maleadt commented Jul 18, 2023

Another (more advanced) tip may be @cuda maxregs, even though that forces to spill it may push the register usage below a threshold, e.g., allowing the thread scheduler to double the amount of active threads.

@maleadt maleadt added documentation Improvements or additions to documentation needs changes Changes are needed. labels Aug 18, 2023
@maleadt
Copy link
Member

maleadt commented Sep 19, 2023

Great stuff, thanks! I'll merge this already so that it can be part of the docs of the upcoming release, but feel free to create follow-up PRs of course.

@maleadt
Copy link
Member

maleadt commented Sep 19, 2023

Also, it might be good to attach [skip ci] or at least [skip tests] to commit messages, to avoid needless CI runs.

@maleadt maleadt marked this pull request as ready for review September 19, 2023 07:57
@maleadt maleadt merged commit 2fa6572 into JuliaGPU:master Sep 19, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation needs changes Changes are needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants