CUSOLVER: Explicitly pass NULL when not requesting svd outputs. #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1934 +/- ##
==========================================
+ Coverage 61.99% 62.00% +0.01%
==========================================
Files 150 150
Lines 12489 12498 +9
==========================================
+ Hits 7743 7750 +7
- Misses 4746 4748 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0D arrays are too cute IMO; sure it's convenient to be able to query
strides, but it's a confusing sight when tracing API calls, and causes unnecessary allocations.I also tried enabling support for
m > nsvd, as the docs don't mention it being unsupported, but it does still fail...