Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't DCE the exception flag. #18

Merged
merged 1 commit into from
May 26, 2020
Merged

Don't DCE the exception flag. #18

merged 1 commit into from
May 26, 2020

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented May 25, 2020

This improves output while running under CUDA memcheck, avoiding
plenty API failures when not finding the global.

Needs LLVM 1.5 tag.

@maleadt maleadt added enhancement New feature or request codegen labels May 25, 2020
@maleadt maleadt force-pushed the tb/dont_dce_exceptionflag branch from 5f2cffe to 721c7ae Compare May 25, 2020 12:56
@maleadt maleadt marked this pull request as ready for review May 25, 2020 13:12
@maleadt maleadt marked this pull request as draft May 25, 2020 14:20
@maleadt maleadt force-pushed the tb/dont_dce_exceptionflag branch 2 times, most recently from c050672 to 3cce5e1 Compare May 26, 2020 07:24
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #18 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   88.69%   88.77%   +0.07%     
==========================================
  Files          26       26              
  Lines        1442     1452      +10     
==========================================
+ Hits         1279     1289      +10     
  Misses        163      163              
Impacted Files Coverage Δ
src/memory/dummy.jl 91.30% <ø> (ø)
src/memory/simple.jl 92.64% <ø> (ø)
src/memory/split.jl 93.51% <ø> (ø)
src/compiler/exceptions.jl 97.50% <100.00%> (+0.27%) ⬆️
src/memory.jl 78.42% <100.00%> (+0.46%) ⬆️
src/memory/binned.jl 92.65% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68feb1...f55cef0. Read the comment docs.

@maleadt maleadt marked this pull request as ready for review May 26, 2020 10:39
This improves output while running under CUDA memcheck, avoiding
plenty API failures when not finding the global.
@maleadt maleadt force-pushed the tb/dont_dce_exceptionflag branch from 3cce5e1 to f55cef0 Compare May 26, 2020 10:53
@maleadt maleadt merged commit e9a7ae6 into master May 26, 2020
@maleadt maleadt deleted the tb/dont_dce_exceptionflag branch May 26, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant