Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make append!! work with DataFrames #32

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Make append!! work with DataFrames #32

merged 1 commit into from
Nov 4, 2019

Conversation

tkf
Copy link
Member

@tkf tkf commented Nov 4, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #32 into master will decrease coverage by 2.97%.
The diff coverage is 65.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   88.94%   85.96%   -2.98%     
==========================================
  Files          14       16       +2     
  Lines         199      228      +29     
==========================================
+ Hits          177      196      +19     
- Misses         22       32      +10
Impacted Files Coverage Δ
src/base.jl 94.23% <ø> (ø) ⬆️
src/BangBang.jl 100% <100%> (ø) ⬆️
src/dataframes.jl 100% <100%> (ø)
src/dataframes_impl.jl 61.53% <61.53%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c813153...f2936fc. Read the comment docs.

@tkf tkf merged commit f2936fc into master Nov 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the DataFrames branch November 4, 2019 08:56
tkf added a commit that referenced this pull request Sep 6, 2020
Using commit:
Workaround over-sensitive ambiguity detection from JuliaLang/julia#36962 (#32)
JuliaTesting/Aqua.jl@fe03e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants