Add Excel module #10
Open
Add Excel module #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a default yearfrac (Excel.Thirty360)
EricForgy
force-pushed
the
ef/excel_module
branch
from
f763c48
to
4fb16f4
Compare
…360. Made this the default daycount.
|
Is there much point duplicating the docs in the Excel module? Also, do the docs build correctly? |
|
I was thinking we'd need to duplicate the docs so we see the right thing when you ?Excel.Thirty360. If that is not needed, we can remove the redundant docs I guess :) |
|
No, we could just add it as a duplicate form to the docstring. |
Edit: I had a look at the documentation for Documentation :) I think we could reduce the redundancy by doing something like @doc (@doc ThirtyU360) Excel.Thirty360Is that what you mean? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.