Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lu deprecation warning on julia v1.7+ #284

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Fix lu deprecation warning on julia v1.7+ #284

merged 1 commit into from
Jun 25, 2021

Conversation

dkarrasch
Copy link
Contributor

I'm not sure why you had the InteractiveUtils subtype method imported. I found no use of it in the package, so I removed that dependency. I also bumped the patch version. If you don't like any of those "extra" edits, no problem, I'll revert them if preferred.

@coveralls
Copy link

coveralls commented Jun 25, 2021

Coverage Status

Coverage decreased (-53.3%) to 42.805% when pulling 7a70ae3 on dkarrasch:dk/lufix into f2e4c83 on JuliaDiff:master.

@lbenet
Copy link
Member

lbenet commented Jun 25, 2021

Thanks a lot for cleaning this as well as solving #281!

Regarding InteractiveUtils, I guess it was a leftover of some experiments... I was trying to distinguish types which are Number but not AbstractSeries, which i named NumberNotSeries, from the universe of Number; my idea was to do this dynamically. But it did not worked out when other packages were loaded (say ModelingToolKit.jl); see #242. So now NumberNotSeries is simply the union of Real and Complex.

@lbenet
Copy link
Member

lbenet commented Jun 25, 2021

Anyway, I'm merging, and tag the new version. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants