Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to upcoming effects change #512

Closed
wants to merge 1 commit into from
Closed

Adjust to upcoming effects change #512

wants to merge 1 commit into from

Conversation

Keno
Copy link
Contributor

@Keno Keno commented Jan 22, 2022

This is for JuliaLang/julia#43852.

Probably hold off on merging until the review phase is through,
but the PR is here for people who want to work on the branch
and need Revise to work.

This is for JuliaLang/julia#43852.

Probably hold off on merging until the review phase is through,
but the PR is here for people who want to work on the branch
and need Revise to work.
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #512 (eb3798b) into master (99893a0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #512   +/-   ##
=======================================
  Coverage   84.68%   84.69%           
=======================================
  Files          12       12           
  Lines        2403     2404    +1     
=======================================
+ Hits         2035     2036    +1     
  Misses        368      368           
Impacted Files Coverage Δ
src/optimize.jl 96.92% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99893a0...eb3798b. Read the comment docs.

@Keno
Copy link
Contributor Author

Keno commented Feb 1, 2022

The representation in Base was changed. This will no longer be required.

@Keno Keno closed this Feb 1, 2022
@KristofferC KristofferC deleted the kf/43852 branch February 21, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant