Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go back to using a Vector for recycled frames #245

Merged
merged 2 commits into from
Mar 31, 2019
Merged

Conversation

KristofferC
Copy link
Member

Before

julia> @time (p = @interpret(plot(rand(5))); @interpret(display(p)))
 12.059313 seconds (63.78 M allocations: 2.143 GiB, 2.58% gc time)

julia> @time (p = @interpret(plot(rand(5))); @interpret(display(p)))
 12.198480 seconds (65.08 M allocations: 2.175 GiB, 2.66% gc time)

After

julia> @time (p = @interpret(plot(rand(5))); @interpret(display(p)))
  9.768135 seconds (65.32 M allocations: 2.052 GiB, 2.97% gc time)

julia> @time (p = @interpret(plot(rand(5))); @interpret(display(p)))
  9.531303 seconds (64.33 M allocations: 2.011 GiB, 3.06% gc time)

@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #245 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
+ Coverage   87.13%   87.15%   +0.01%     
==========================================
  Files          14       14              
  Lines        1982     1985       +3     
==========================================
+ Hits         1727     1730       +3     
  Misses        255      255
Impacted Files Coverage Δ
src/construct.jl 92.18% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a974c71...81886bc. Read the comment docs.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I am surprised our former troubles didn't rear up, but perhaps just emptying on initialization solved it? Anyway, very nice performance boost.

@KristofferC KristofferC merged commit 19d888b into master Mar 31, 2019
@KristofferC KristofferC deleted the kc/junk_array branch March 31, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants